fabric8io / openshift-elasticsearch-plugin

Apache License 2.0
27 stars 21 forks source link

Read index-pattern data from files rather than hardcoded constants #49

Closed jcantrill closed 7 years ago

jcantrill commented 8 years ago

as mentioned in #48

richm commented 8 years ago

The kibana index-pattern data is a single line, several thousand byte JSON blob hardcoded into constant strings in the DocumentBuilder class. Instead, we should read this data from JSON or YAML files. viaq can generate the elasticsearch index templates as json or yaml files - it could also generate the corresponding kibana index-pattern data and other config data. https://github.com/ViaQ/elasticsearch-templates/issues/17

richm commented 8 years ago

Partially addressed by https://github.com/fabric8io/openshift-elasticsearch-plugin/pull/51 - if using elasticsearch index templates, kibana index patterns are not needed

jcantrill commented 7 years ago

Closing as will be fixed by #65