bug 1431551. Node does not survive upgrade

fabric8io / openshift-elasticsearch-plugin

Apache License 2.0

27 stars 21 forks source link

bug 1431551. Node does not survive upgrade #68

Closed jcantrill closed 7 years ago

jcantrill commented 7 years ago

This PR fixes:

Concurrency issues while seeding initial ACL
Deletes SG index on start up if exists
Adds state to seeding ACLs
Forces SG to load all ACL docs on write update
Updates debug logs to pretty print doc info

jcantrill commented 7 years ago

Updated to work in conjunction with https://github.com/openshift/origin-aggregated-logging/pull/353 which this blocks.

cc @richm @ewolinetz

jcantrill commented 7 years ago

@richm @portante @richm All of these formatting issues are because I have chosen to replace tabs with spaces. We as a follow on should convert everything to spaces and then add a lint job to check.

ewolinetz commented 7 years ago

@jcantrill can i request that formatting changes are put in a separate commit from the code changes? (same PR) just to make it easier to read?

jcantrill commented 7 years ago

@ewolinetz I'm not sure how I can easily rollback the changes. I think once we get it back into master implementing some lint task is the order.

richm commented 7 years ago

rollback the changes

git reset HEAD file ... file then git add -p is your friend