search

fabric8io / openshift-jenkins-s2i-config

Config repo used to build a customised OpenShift Jenkins image using S2I
6 stars 23 forks source link

fix(#4006): Set versions of transitive plugins #186

Closed lordofthejars closed 6 years ago

lordofthejars commented 6 years ago

fixes https://github.com/openshiftio/openshift.io/issues/4006 : Set versions of transitive plugins to avoid Jenkins download the latest ones

This PR resolves the errors that can be found when starting a new Jenkins Docker image. If a plugin is not specified in plugins.txt but it is required transitively then Jenkins goes to configured update center and downloads the latest version, even if this version is not compatible with current Jenkins version. In this case, if the plugin is not compatible with Jenkins version the image is created but when it is started in OSIO, error message about incompatibility are thrown.


Jul 16, 2018 5:11:59 PM jenkins.InitReactorRunner$1 onTaskFailed
SEVERE: Failed Loading plugin Jenkins Design Language v1.6.2 (jenkins-design-language)
java.io.IOException: Jenkins Design Language v1.6.2 failed to load.
 - You must update Jenkins from v2.93 to v2.107.2 or later to run this plugin.

Jul 16, 2018 5:11:59 PM jenkins.InitReactorRunner$1 onTaskFailed
SEVERE: Failed Loading plugin Blue Ocean Core JS v1.6.2 (blueocean-core-js)
java.io.IOException: Blue Ocean Core JS v1.6.2 failed to load.
 - You must update Jenkins from v2.93 to v2.107.2 or later to run this plugin.
 - Jenkins Design Language v1.6.2 failed to load. Fix this plugin first.

This PR fixes the problems encountered because of transitive Blue Ocean plugins.

fabric8cd commented 6 years ago

@lordofthejars snapshot Jenkins image is available. docker pull fabric8/jenkins-openshift:SNAPSHOT-PR-186-1

fabric8cd commented 6 years ago

@lordofthejars snapshot Jenkins image is available. docker pull fabric8/jenkins-openshift:SNAPSHOT-PR-186-2

fabric8cd commented 6 years ago

@lordofthejars snapshot Jenkins image is available. docker pull fabric8/jenkins-openshift:SNAPSHOT-PR-186-3

lordofthejars commented 6 years ago

TEsted and working without any error

lordofthejars commented 6 years ago

@rupalibehera Cannot add you as a reviewer. Can you review it?

hrishin commented 6 years ago

Tested this image and Jenkins logs https://pastebin.com/ExKa81Wi. This fix looks good. Thanks @lordofthejars!

Could you please update the commit message with an issue reference?

piyush-garg commented 6 years ago

Tested this and it works fine for me. LGTM.

Can you just fix one small change? Also If you can add a descriptive commit message, it will be good.

fabric8cd commented 6 years ago

@lordofthejars snapshot Jenkins image is available. docker pull fabric8/jenkins-openshift:SNAPSHOT-PR-186-4

rupalibehera commented 6 years ago

Tested on my tenant, looks good.