search

fabric8io / openshift-jenkins-s2i-config

Config repo used to build a customised OpenShift Jenkins image using S2I
6 stars 23 forks source link

Enhance Analytics Plugin #230

Closed yzainee-zz closed 5 years ago

yzainee-zz commented 5 years ago

Changes added to support the new osio pipeline where the analytics flow should not fail if the manifest files are not found.

The .hpi file was built from https://github.com/fabric8-analytics/fabric8-analytics-jenkins-plugin/pull/21

Tag: https://github.com/fabric8-analytics/fabric8-analytics-jenkins-plugin/releases/tag/0.3.3 Resolves: https://openshift.io/openshiftio/Openshift_io/plan/detail/1216

centos-ci commented 5 years ago

Can one of the admins verify this patch?

piyush-garg commented 5 years ago

[test]

fabric8cd commented 5 years ago

Good news @yzainee snapshot Jenkins image is available. docker pull fabric8/jenkins-openshift:SNAPSHOT-PR-230-122

piyush-garg commented 5 years ago

[test]

fabric8cd commented 5 years ago

Good news @yzainee snapshot Jenkins image is available. docker pull fabric8/jenkins-openshift:SNAPSHOT-PR-230-126

hrishin commented 5 years ago

[test]

fabric8cd commented 5 years ago

Good news @yzainee snapshot Jenkins image is available. docker pull fabric8/jenkins-openshift:SNAPSHOT-PR-230-127

piyush-garg commented 5 years ago

[test]

fabric8cd commented 5 years ago

Good news @yzainee snapshot Jenkins image is available. docker pull fabric8/jenkins-openshift:SNAPSHOT-PR-230-128

piyush-garg commented 5 years ago

@yzainee If your work is in progress, please add the DNM label

yzainee-zz commented 5 years ago

@piyush-garg No there is no more changes in the plugin. Was just adding some logs etc for more clarification as to what is sent to our plugin. The PR is good to be merged.

yzainee-zz commented 5 years ago

@piyush-garg @hrishin https://paste.centos.org/view/3435a166 Build Logs

piyush-garg commented 5 years ago

Thanks, @yzainee I will also give it a try today and then merge.

piyush-garg commented 5 years ago

@yzainee Can you please change commit message.

yzainee-zz commented 5 years ago

@piyush-garg done.

piyush-garg commented 5 years ago

@yzainee In the other commit message, you have mentioned - removed version file. That is not part of this patch, Can you please check once again.

piyush-garg commented 5 years ago

It will be better if you squash both the commits and provide a commit message like the second commit. Thanks

yzainee-zz commented 5 years ago

@piyush-garg we used to update the version file as well earlier. After discussion with @hrishin , I removed the version file which i had updated in the 1st commit as its no longer required.

piyush-garg commented 5 years ago

[test]

fabric8cd commented 5 years ago

Good news @yzainee snapshot Jenkins image is available. docker pull fabric8/jenkins-openshift:SNAPSHOT-PR-230-129