search

fabric8io / osio-pipeline

DSL and utility functions in groovy for running Jenkins OSIO Pipeline
13 stars 17 forks source link

Updating Readme.md #122

Closed rupalibehera closed 5 years ago

rupalibehera commented 5 years ago

Updating Readme.md with below changes

  1. runTest API usage
  2. testNamespace API usage
  3. adding envVar as a parameter in spawn API

fixes https://github.com/fabric8io/osio-pipeline/issues/119 and continuation of https://github.com/fabric8io/osio-pipeline/pull/91

rupalibehera commented 5 years ago

@piyush-garg @hrishin I have updated the patch, let me know if we can merge it.

piyush-garg commented 5 years ago

@rupalibehera Can we do the same envVar -> envVars in spec also. Basically here

  1. https://github.com/fabric8io/osio-pipeline/blob/master/vars/spawn.groovy#L81
  2. https://github.com/fabric8io/osio-pipeline/blob/master/vars/spawn.groovy#L89
  3. https://github.com/fabric8io/osio-pipeline/blob/master/vars/spawn.groovy#L46
rupalibehera commented 5 years ago

@rupalibehera Can we do the same envVar -> envVars in spec also. Basically here

  1. https://github.com/fabric8io/osio-pipeline/blob/master/vars/spawn.groovy#L81
  2. https://github.com/fabric8io/osio-pipeline/blob/master/vars/spawn.groovy#L89
  3. https://github.com/fabric8io/osio-pipeline/blob/master/vars/spawn.groovy#L46

@piyush-garg done

piyush-garg commented 5 years ago

@hrishin Your requests seem addressed, merging this.