fabric8io / vertx-maven-plugin

Vert.x Maven Plugin - moved to https://github.com/reactiverse/vertx-maven-plugin
https://github.com/reactiverse/vertx-maven-plugin
Apache License 2.0
25 stars 5 forks source link

Redeployment with a launcher extending io.vertx.core.Launcher #103

Closed cescoffier closed 7 years ago

cescoffier commented 7 years ago

So far, it does not work...

When using a launcher class extending Launcher, we forward the args to the Launcher. However, as it's not the Vert.x Launcher we don't build the command line.

kameshsampath commented 7 years ago

@cescoffier - not able to understand, you mean to say the new Launcher().dispatch(args) kind of thing will not pass the args ?

cescoffier commented 7 years ago

When someone uses a launcher extending the io.vertx.core.Launcher, it expects the regular Launcher parameter (run verticle....). Right now, we don't pass any parameter, and we fail with an obscure error (ClassNotFound redeploy-termination-period=1000).

cescoffier commented 7 years ago

To reproduce it, just create a project with a custom launcher extending io.vertx.core.Launcher with the following main:

public class MyLauncher extends Launcher {
  public static void main String[]) {
      new MyLauncher().dispatch(args);
  }
}

With this launcher we neither, run / start nor manage the redeployment.

kameshsampath commented 7 years ago

got it thanks, let me check and will fix it up

cescoffier commented 7 years ago

CC @ctranxuan