fabric8io / vertx-maven-plugin

Vert.x Maven Plugin - moved to https://github.com/reactiverse/vertx-maven-plugin
https://github.com/reactiverse/vertx-maven-plugin
Apache License 2.0
25 stars 5 forks source link

Excludes Implementation -itr#1 #116

Closed kameshsampath closed 7 years ago

kameshsampath commented 7 years ago

WIP: excluding transitive dependency of excludes as well

@cescoffier / @rhuss - i have made the first iteration of the exclude implemetation, can you please review and let me know your comments. I am adding a bunch of IT cases, but thought to get the review done early.

currently the excludes happens but I see the transitive dependencies stills get carried in .. need your thoughts ..

cescoffier commented 7 years ago

I'm thinking about another way to describe the content of the fat jar. Something closed to the Assembly plugin.

It should provide:

I was thinking about something like this:

<content>
 <dependencySet>
  <includes>
    <include>*:jar</include>
  </includes>
  <excludes>
    <exclude>foo</exclude>
  </exclude>
 </dependencySet>
 <fileSets>
    <fileSet>
      <useDefaultExcludes>false</useDefaultExcludes>
      <excludes>
        <exclude>**/target/**</exclude>
      </excludes>
    </fileSet>
  </fileSets>
</content>

Basically doing something like in: http://maven.apache.org/plugins/maven-assembly-plugin/advanced-descriptor-topics.html (reusing the same classes and logic)

kameshsampath commented 7 years ago

closing this as @cescoffier has reimplemented this in the other PR.

cescoffier commented 7 years ago

just to be clear - it's not yet implemented ;-)