fabricebrito / ambit2gpx

Automatically exported from code.google.com/p/ambit2gpx
0 stars 0 forks source link

Defect fix in 1.6 - cadence. Tested additional feature "Power" #6

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Run against Ambit 2 cycling xml with Cadence (Bike Pod) and BikePower (Power 
Pod)
2.
3.

What is the expected output? What do you see instead?
Cadence information not in output gpx.  Incomplete development!?
Power information not in output gpx - I have developed a working (for Strava) 
amendment

What version of the product are you using? On what operating system?
ambit2gpx_1.6  Mac OSX 10.9.2

Please provide any additional information below.

I have debugged and added both features in a manner compatible with Strava 
upload, following the coding practices and conventions in version 1.6.  This 
modified version is attached.

Example track point segment in new output:

<trkpt lat="12.123456" lon="-0.123456">
  <ele>45</ele>
  <time>2014-03-05T10:18:32Z</time>

<extensions> 
  <gpxtpx:TrackPointExtension> 
    <gpxtpx:hr>119</gpxtpx:hr>
    <gpxtpx:atemp>11.15</gpxtpx:atemp>
    <gpxtpx:cad>88</gpxtpx:cad>
  </gpxtpx:TrackPointExtension> 
  <power>140.0</power>
</extensions>

</trkpt>

Original issue reported on code.google.com by peterjnc...@gmail.com on 5 Mar 2014 at 4:00

Attachments:

GoogleCodeExporter commented 8 years ago
Detail regarding non-workign cadence info:

Line 62 read:  cadext = "<gpxtpx:cad>{hr}</gpxtpx:cad>".format(cadence=cadence)
Should read: cadext = 
"<gpxtpx:cad>{cadence}</gpxtpx:cad>".format(cadence=cadence)

Missing section in for loop:

if key.lower() == "cadence":
       self.__cadence = int((float(node.firstChild.nodeValue))*60+0.5)

Original comment by peterjnc...@gmail.com on 5 Mar 2014 at 6:17

GoogleCodeExporter commented 8 years ago
I'll handle this one.

Original comment by jconr...@gmail.com on 22 Mar 2014 at 10:50

GoogleCodeExporter commented 8 years ago
I'll look into it soon.

Original comment by jconr...@gmail.com on 22 Mar 2014 at 10:50

GoogleCodeExporter commented 8 years ago
The change for this is done now.

Original comment by jconr...@gmail.com on 22 Mar 2014 at 10:51