fabricecaruso / old-batocera-ports-obsolete

Obsolete. See RetroBat-Official/emulatorlauncher
16 stars 13 forks source link

Rpcs3: Improvement to get the correct EBOOT.BIN path #148

Open fabyo opened 1 year ago

fabyo commented 1 year ago

ps3 games there are at least 3 different paths to EBOOT.BIN "PS3_GAME\USRDIR\EBOOT.BIN" "GAME\PS3_GAME\USRDIR\EBOOT.BIN" "USRDIR\EBOOT.BIN"

I created an easier way to fetch the EBOOT.BIN without using ifs:

        if (Directory.Exists(rom))
        {
            string eboot;
            string[] files = Directory.GetFiles(rom, "EBOOT.BIN", SearchOption.AllDirectories);

            if (files.Length > 0)
            {
                eboot = Path.Combine(rom, files[0]);
            }
Tartifless commented 1 year ago

Hi,

Are we 100% sure there is always 1 eboot.bin file in the folders, and that there might not be several ?

fabyo commented 1 year ago

yes, from what I've already tested, I've tested more than 200 games and they follow the same pattern of the 3 folders, and it helped a lot because after we found out that there are games that use the GAME\PS3_GAME folder, the games that weren't running started to run

Tartifless commented 1 year ago

ok

Tartifless commented 1 year ago

https://github.com/fabricecaruso/batocera-ports/pull/149 contains this change