search

fabricedesre / servonk

Servo on Gonk
Mozilla Public License 2.0
85 stars 11 forks source link

Scripts assume the build is release #4

Open trufae opened 6 years ago

trufae commented 6 years ago

Those platform/glutin/support/scripts/*.sh assume the build was done in release mode, it should check which one is the most recent (release|debug) and use that, or let the user specify it with an env var.

screen shot 2018-04-18 at 10 06 21
fabricedesre commented 6 years ago

I would go with a parameter like we do in https://github.com/fabricedesre/servonk/blob/master/platform/gonk/support/scripts/flash.sh#L8

radare commented 6 years ago

why assume release?

On 18 Apr 2018, at 16:23, Fabrice Desré notifications@github.com wrote:

I would go with a parameter like we do in https://github.com/fabricedesre/servonk/blob/master/platform/gonk/support/scripts/flash.sh#L8 https://github.com/fabricedesre/servonk/blob/master/platform/gonk/support/scripts/flash.sh#L8 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fabricedesre/servonk/issues/4#issuecomment-382404680, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lhC0K3EByGBvQfoTCOQ2-Z3oYH0Iks5tp0xugaJpZM4TZm5i.

fabricedesre commented 6 years ago

Because there is no reason to use slower builds as default ones?

radare commented 6 years ago

default is debug unless you pass the —release flag

On 18 Apr 2018, at 16:57, Fabrice Desré notifications@github.com wrote:

Because there is no reason to use slower builds as default ones?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fabricedesre/servonk/issues/4#issuecomment-382416941, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lrUdGKfaN7CqxlFkPK6Ch9qWfBgcks5tp1R1gaJpZM4TZm5i.

fabricedesre commented 6 years ago

Yeah, for the build script. We need to change that actually. Wanna fix that?

radare commented 6 years ago

yes i can send a PR for this, but not now gtg busy irl

On 18 Apr 2018, at 17:02, Fabrice Desré notifications@github.com wrote:

Yeah, for the build script. We need to change that actually. Wanna fix that?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fabricedesre/servonk/issues/4#issuecomment-382418615, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lvAaJK52Xc8I93uxfQ4_7tfsOMbXks5tp1WJgaJpZM4TZm5i.