[Feature]: Upgrade dependency jsdom

zhe-he commented 3 months ago

CheckList

[X] I agree to follow this project's Code of Conduct
[X] I have read and followed the Contributing Guide
[X] I have searched and referenced existing issues, feature requests and discussions
[X] I am filing a FEATURE request.

Description

Every time I install fabric.js, my console gives me two warnings. I noticed that these two warnings are related to the optional dependency jsdom (version 20.0.1 from two years ago). The latest version is now 24.x. I hope to upgrade the jsdom dependency to prevent the following warnings when installing fabric.js:

npm warn deprecated abab@2.0.6: Use your platform's native atob() and btoa() methods instead
npm warn deprecated domexception@4.0.0: Use your platform's native DOMException instead

Current State

Upgrading jsdom may require modifying code related to node-canvas.

Additional Context

No response

asturur commented 3 months ago

We support node 18+, so any JSDOM dependecy that still support node18 is fine. Check which is the latest that still does that and you can open a PR to upgrade

gloriousjob commented 2 months ago

According to the changeelog, 23 made 18 the minimum and that was the last node note so the latest should work. The only thing that sticks out is this note in v21: A potentially-breaking bug fix: Fixed the window, document, location, and top properties of Window to be non-configurable. (ExE-Boss)

Outside of this, the other releases appear to be because of the new node minimum or things pertaining to newer features.

fabricjs / fabric.js