[Bug]:f abric: Trying to initialize a canvas that has already been initialized. Did you forget to dispose the canvas

vaynevayne commented 3 weeks ago

CheckList

[X] I agree to follow this project's Code of Conduct
[X] I have read and followed the Contributing Guide
[X] I have read and followed the Issue Tracker Guide
[X] I have searched and referenced existing issues and discussions
[X] I am filing a BUG report.
[X] I have managed to reproduce the bug after upgrading to the latest version
[X] I have created an accurate and minimal reproduction

Version

6.0.2

In What environments are you experiencing the problem?

No response

Node Version (if applicable)

None

Link To Reproduction

https://stackblitz.com/edit/vitejs-vite-sujben?file=src%2FReactFabric%2Fstore%2Findex.ts,src%2FReactFabric%2FbaseFabric%2FBaseFabric.ts,src%2FReactFabric%2Fcomponents%2FStoreUpdater%2Findex.tsx,src%2FReactFabric%2Fcontainer%2FFabric%2Findex.tsx

Steps To Reproduce

yarn run dev

Expected Behavior

no error

Actual Behavior

error in console

Error Message & Stack Trace

react-dom_client.js?v=7d540ee2:16670 Uncaught c: fabric: Trying to initialize a canvas that has already been initialized. Did you forget to dispose the canvas?
    at wn.createLowerCanvas (https://vitejsvitesujben-v1mp--5173--24eaa195.local-credentialless.webcontainer.io/node_modules/.vite/deps/fabric.js?v=a9b44b02:890:47)
    at new de (https://vitejsvitesujben-v1mp--5173--24eaa195.local-credentialless.webcontainer.io/node_modules/.vite/deps/fabric.js?v=a9b44b02:884:21)
    at new wn (https://vitejsvitesujben-v1mp--5173--24eaa195.local-credentialless.webcontainer.io/node_modules/.vite/deps/fabric.js?v=a9b44b02:3490:5)
    at An.initElements (https://vitejsvitesujben-v1mp--5173--24eaa195.local-credentialless.webcontainer.io/node_modules/.vite/deps/fabric.js?v=a9b44b02:3546:21)
    at new _fe (https://vitejsvitesujben-v1mp--5173--24eaa195.local-credentialless.webcontainer.io/node_modules/.vite/deps/fabric.js?v=a9b44b02:938:86)
    at new _Sn (https://vitejsvitesujben-v1mp--5173--24eaa195.local-credentialless.webcontainer.io/node_modules/.vite/deps/fabric.js?v=a9b44b02:3529:5)
    at new An (https://vitejsvitesujben-v1mp--5173--24eaa195.local-credentialless.webcontainer.io/node_modules/.vite/deps/fabric.js?v=a9b44b02:3838:5)
    at https://vitejsvitesujben-v1mp--5173--24eaa195.local-credentialless.webcontainer.io/src/ReactFabric/container/Fabric/index.tsx:38:27
    at commitHookEffectListMount (https://vitejsvitesujben-v1mp--5173--24eaa195.local-credentialless.webcontainer.io/node_modules/.vite/deps/react-dom_client.js?v=7d540ee2:16915:34)
    at invokePassiveEffectMountInDEV (https://vitejsvitesujben-v1mp--5173--24eaa195.local-credentialless.webcontainer.io/node_modules/.vite/deps/react-dom_client.js?v=7d540ee2:18324:19)
(anonymous) @   index.tsx:32
Show 17 more frames

vaynevayne commented 3 weeks ago

My removal problem disappeared. Does strict mode not support?

asturur commented 3 weeks ago

Are you using React in strict mode? Hooks will run twice be sure to dispose it properly. Imho strict mode does not make sense, i wish there was a way to disable it for portions of the app

fabricjs / fabric.js

[Bug]:f abric: Trying to initialize a canvas that has already been initialized. Did you forget to dispose the canvas #10136