fabricjs / fabric.js

Javascript Canvas Library, SVG-to-Canvas (& canvas-to-SVG) Parser
http://fabricjs.com
Other
29.07k stars 3.51k forks source link

Hook up `npm version` for easier (and more frequent) publishing #2813

Closed JSteunou closed 4 years ago

JSteunou commented 8 years ago

Hi,

this is more a request than a usage question so I write down here, let me know if it would be better in google group.

fabric.js is real jewel when it comes Canvas in JavaScript, and I could not thank you enough for that. Last year we were excited to see that the process of a release candidate for the 1.6.0 was started. It has been more than 6 months now.

I have the feeling you all want to reach the stars and set goals hard to reach before a possible RC2 or final release. Would it be better to plan littler steps and having regular RC we all can test, play with and make a final 1.6.0 release sooner than never?

It's a common mistake others did before you. JavaScript es4 and PHP6 for example. Please do not fall into that trap.

What can we do to help you make or plan this release?

asturur commented 8 years ago

I was planning to make a nightly build system and place a link somewhere.

kangax commented 8 years ago

I agree that we need faster releases; I just simply didn't have time to make a proper release. @asturur would you be able to?

asturur commented 8 years ago

Give me list of steps you have. Update npm, update bower,update tweeter, update docs...

kangax commented 8 years ago

0) Don't forget to pull new changes 1) npm run all 2) make sure there are no errors 3) bump version, npm run all & commit 4) Tag new version

git tag v1.x.x git push --tags 5) npm publish 6) Update build files on fabricjs.com (commit, push) 7) Submit pull request to cdnjs 8) Update cdnjs link on fabricjs.com 9) Ask @jsfiddle on twitter to update 10) Prepare list of changes 11) Write about new version + changes on Google Group 12) Tweet link to Google Group

On Thu, Feb 25, 2016 at 2:24 PM, Andrea Bogazzi notifications@github.com wrote:

Give me list of steps you have. Update npm, update bower,update tweeter, update docs...

— Reply to this email directly or view it on GitHub https://github.com/kangax/fabric.js/issues/2813#issuecomment-189011501.

JSteunou commented 8 years ago

steps 1 to 5 can be done with npm version and npm hooks.

for example $ npm version minor will increment to 1.7.0 the version in package.json, create a commit and a tag. You can personalize the tag and message via .npmrc or cli arguments.

If you have to do things before publish you can use prepublish but be aware this one is triggered by npm install too which lead to hack like this "prepublish": "in-publish && npm run build || not-in-publish"

You can do tasks after 5 with postpublish.

kangax commented 8 years ago

@JSteunou never knew about npm version, that's really awesome, thanks! if you can make a PR that would very helpful since I'm a bit constrained on time now.

JSteunou commented 8 years ago

I which I could, hard to find time since a while. @asturur if you're on it I could help you with some code review. The recipe is above, the most valuable missing ingredient is time.

asturur commented 8 years ago

i'm happy to learn. But first i need a npm account i think.

JSteunou commented 8 years ago

For testing purpose I use https://github.com/rlidwka/sinopia and set "publishConfig": {"registry": "http://localhost:4873/"} in the package.json of my projects

This will allow you to test your script at home without publishing for real ;)

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.