fix(filters) RemoveColor has missing getFragmentSource method ( typo )

fabricjs / fabric.js

Javascript Canvas Library, SVG-to-Canvas (& canvas-to-SVG) Parser

http://fabricjs.com

Other

28.82k stars 3.5k forks source link

fix(filters) RemoveColor has missing getFragmentSource method ( typo ) #9911

Closed 271642183 closed 3 months ago

271642183 commented 3 months ago

Description

This is a bug related to the 'removecolor filter' that someone raised in the following link, but the issue has not been fixed yet. So, I submitted this PR. This is my first time submitting a PR, so I hope you can teach me more if there are any mistakes or omissions.

https://github.com/fabricjs/fabric.js/issues/9386

In Action

none

codesandbox[bot] commented 3 months ago

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders
Open Preview

asturur commented 3 months ago

Thank you for fixing this. Adding a test at this stage is complicated, unless you are experienced with playwright. I ll merge this fix, then i'll add a test for fitlers.

Please go in the CHANGELOG.MD file and add a line as you see done for the other PRs on top of the last commit line

271642183 commented 3 months ago

Teacher, do you think this is okay？