fabrix-app / fabrix

Strongly Typed Modern Web Application Framework for Node.js and Browsers
Other
107 stars 5 forks source link

chore(): Lifecycle listeners should throw a warning if the lifecycle event will not exist #14

Open scott-wyatt opened 6 years ago

scott-wyatt commented 6 years ago

Issue Description

Lifecycle listeners should throw a warning if the lifecycle event will not exist.

Environment

scott-wyatt commented 4 years ago

Maybe this will be the year! #hacktoberfest

jaumard commented 4 years ago

Not sure there is enough details to be taken into an hacktoberfest ^^ even me who know a bit the subject I don't understand the issue :D

Can you explain more what's need to be done here ? maybe with a use case

scott-wyatt commented 4 years ago

Haha, sorry! Basically, if a spool is waiting for some event like “spool:sequelize:initialized”, if you don’t have spool sequelize installed, that event will never be emitted. So eventually, fabrix timeout will occur and the user won’t know why.

Sent from out and about

On Oct 23, 2019, at 6:48 AM, Jaumard notifications@github.com wrote:

 Not sure there is enough details to be taken into an hacktoberfest ^^ even me who know a bit the subject I don't understand the issue :D

Can you explain more what's need to be done here ? maybe with a use case

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

jaumard commented 4 years ago

now I understand :p ha ha no worry :)

but how can we do that ? just parsing the event to retrieve sequelize and check that the spool is available under main.spools ? but we have to keep in mind that wanted event can be "or" or "and" (if I remember correctly ^^) so we need to manage that logic too