fabrizioschiavi / pragmatapro

PragmataPro font is designed to help pros to work better
https://www.fsd.it/shop/fonts/pragmatapro/
1.42k stars 40 forks source link

[TODO] ligature could be more generic #134

Open cflewis opened 5 years ago

cflewis commented 5 years ago

I just bought Pragmata Pro, and I am really happy with it. There is just one thing that bums me out, which is the [TODO] is too specific, and I have not encountered it looking like that before.

When I write code, I do not write a TODO like [TODO].

I write it like (in Go):

// TODO:

or

// TODO(cflewis):

I can imagine that there aren't many other combinations of this (a # for languages like Python so a # TODO would probably be all that was needed).

Would it be possible to have // TODO and # TODO trigger with a cool ligature like [TODO] does?

The same goes for FIXME/HACK and all those.

Thank you!

fabrizioschiavi commented 5 years ago

Interesting. Thanks! I can add them with pleasure but I would like to have the confirm that this can't be problematic for other kind of programming languages

cflewis commented 5 years ago

I've written in a lot of programming languages and I can't think of anything where // TODO and # TODO would clash, unless perhaps you were writing a comment with a word that began with TODO. In English, there aren't any:

$ grep "todo" /usr/share/dict/words
mastodon
mastodon's
mastodons

I can't speak for other written languages, though :/

fabrizioschiavi commented 5 years ago

I'm working at the issue. Do you like this solution? Screen Shot 2019-05-16 at 15 42 57

cflewis commented 5 years ago

Looks awesome! πŸ™Œ

On Thu, May 16, 2019 at 6:49 AM Fabrizio Schiavi notifications@github.com wrote:

I'm working at the issue. Do you like this solution? [image: Screen Shot 2019-05-16 at 15 42 57] https://user-images.githubusercontent.com/1576663/57858768-f0a9e300-77f1-11e9-8918-6bd7c57a5cd9.png

β€” You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fabrizioschiavi/pragmatapro/issues/134?email_source=notifications&email_token=AAAKVPCKCX2G3THXEBPQD63PVVQ5BA5CNFSM4GRQB632YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVR3VEQ#issuecomment-493075090, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAKVPF6JY323RVMMGZCHHDPVVQ5BANCNFSM4GRQB63Q .

talios commented 5 years ago

I need this in my life * πŸ’― πŸ‘

fabrizioschiavi commented 5 years ago

Unfortunately the // TODO ligature causes slowdowns and can’t be used 😞

cflewis commented 5 years ago

😭

On Sat, Jul 27, 2019 at 10:57 AM Fabrizio Schiavi notifications@github.com wrote:

Unfortunately the // TODO ligature causes slowdowns and can’t be used 😞

β€” You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fabrizioschiavi/pragmatapro/issues/134?email_source=notifications&email_token=AAAKVPBGTLR7XQCEF5BQ6HTQBSD7TA5CNFSM4GRQB632YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD26P53I#issuecomment-515702509, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAKVPGJ4N5MBAOM42RRG2DQBSD7TANCNFSM4GRQB63Q .

fabrizioschiavi commented 5 years ago

I hope to find in future a good way to add also // TODO ligature. This kind of ligatures in version 0.828 are these:

PragmataPro Highlighted Text Ligatures

ghost commented 5 years ago

Hi, Fabrizio! I just tested PragmataPro Liga in Sublime Text 3.2.1 and VS Code 1.36.1 on Ubuntu and the TODO ligatures are not showing up. They are working on the default text editor though.

keithrussell42 commented 4 years ago

Hi, Fabrizio! I just tested PragmataPro Liga in Sublime Text 3.2.1 and VS Code 1.36.1 on Ubuntu and the TODO ligatures are not showing up. They are working on the default text editor though.

I've also noticed this. I did notice that on Sublime Text when you create a new file and start typing it uses the text for the tab title until you save the file with a name. On my system (Windows using the Monokai Pro theme which uses my defined font for all UI elements) the tab has the ligature but the text does not. Other ligatures do work. I have even enabled the "Discretionary Ligature" font option to see. Is it possible that these ligatures are part of a different stylistic set that I need to enable explicitly? Sublime supports standard ligatures along with calt, and clig out of the box. You can add sets 1 to 10 in the configuration. I tried all of the optional sets but no luck. I gather this is less of an issue with Pragmata Pro and more of an issue with Sublime Text. Before I bug the Sublime folks it would be handy to know what to tell them.

Annotation 2019-11-19 230517

fabrizioschiavi commented 4 years ago

Thanks friends to let me know this. Very helpful. We hope in Sublime Text flexibility πŸ˜‰

keithrussell42 commented 4 years ago

BTW, this also happens in Linux. I've posted in the Sublime Text technical support forum so I'll report back here if I hear anything interesting.

keithrussell42 commented 4 years ago

The Sublime developers have confirmed that for performance reasons runs of alpha-numerics aren't sent to the font engine so these ligatures won't work. At least now I know it's by design. It also explains why the markdown checkboxes don't work.

fabrizioschiavi commented 4 years ago

Thanks @keithrussell42 for this precious information!

tinjaw commented 4 years ago

I am using # TODO in JetBrains' IDEs and it initially uses the ligature, but immediately reverts to plain text. I am uncertain is some other plugin/formatter/rule is causing the reversal.