search

fabrizioschiavi / pragmatapro

PragmataPro font is designed to help pros to work better
https://www.fsd.it/shop/fonts/pragmatapro/
1.42k stars 40 forks source link

Request to patch font for IntelliJ #20

Closed smeevil closed 8 years ago

smeevil commented 8 years ago

Hi there,

Recently the IntelliJ line of editors is able to use ligatures as well. Examples are the Hasklig and FiraCode font.

Due to a bug in the JDK there is a small patch required to make this work until the editors are ready to use Java 9.

As far as I can find out they are talking about "replacing 'DFLT' tag with 'zyyy' tag in GSUB subtable,. The full tread can be found here : https://youtrack.jetbrains.com/issue/IDEA-127539

Looking forward to use this font (with ligatures) in IntelliJ :D

Gerard

fabrizioschiavi commented 8 years ago

Thank you @smeevil for your suggestion! I'll change it and I'll let you try if it works, if you agree

smeevil commented 8 years ago

Yep, Just let me know when you have something that i can test for you :)

IceMan81 commented 8 years ago

@fabrizioschiavi I would be more than happy to test this.

i-am-the-slime commented 8 years ago

@fabrizioschiavi Me too! (this way, I have it earlier!)

smeevil commented 8 years ago

Thank you for the quick support @fabrizioschiavi !

Version PragmataPro-Regular0.823 works like a charm, and more importantly, I have not spotted any render artefacts or slowdown in auto completion popup windows in IntelliJ with the ligatures, which where there using the other fonts.

You can close the issue if you like.

screenshot

IceMan81 commented 8 years ago

@fabrizioschiavi 0.823 is pretty cool! With 0.822 ligatures did not work in the code editor in Intellij, but it used to somewhat work in the Intellij console. With 0.823, it works in the editor in most places. See screenshot of an example, where I expect it to work but doesn't.

Also, I'm not sure its working in the console.

image

@smeevil Could you verify if the font works as expected in the Intellij console?

smeevil commented 8 years ago

It seems it is not working in the console, but this is more a choice that is made by IntelliJ and not by the font.

Regarding your screenshot, i cannot replicate that. see attached image

img

fabrizioschiavi commented 8 years ago

Thank you @smeevil for let me know this issue and its solutions! To everyone interested in the temporary working version of PragmataPro for IntelliJ, contact me directly waiting for the official v_0.823. Thank you to all :smiley:

IceMan81 commented 8 years ago

@smeevil what OS are you on? My screenshot is from Windows. Wrt console, it used to work before with PragmataPro and I think other fonts work on the console. IntelliJ provides an option to enable ligatures on console just like the option for the editor. See the console font settings.

i-am-the-slime commented 8 years ago

It works really well in the new IntelliJ EAP. Can we expect a new version any time soon (including bold and italic :))?

IceMan81 commented 8 years ago

:). I think we have all been asking Fabrizio the same question!! On Thu, May 26, 2016 at 03:59 Mark Eibes notifications@github.com wrote:

It works really well in the new IntelliJ EAP. Can we expect a new version any time soon (including bold and italic :))?

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/fabrizioschiavi/pragmatapro/issues/20#issuecomment-221840798