search

fabsig / GPBoost

Combining tree-boosting with Gaussian process and mixed effects models
Other
574 stars 46 forks source link

docs: replace formulas with Latex in README #116

Closed Ab2nour closed 1 year ago

Ab2nour commented 1 year ago

Formulas in README were previously written as code blocks. I thought it would be "nicer" to have them as Latex formulas.

Please feel free to tell me if you judge this inexact or inappropriate.

fabsig commented 1 year ago

Also it would be nicer if $y$ and $m$ start at the same position. You can eg use \begin{equation} \begin{split} ...

Ab2nour commented 1 year ago

I fixed both problems!

Do not hesitate if you have any other remarks.

fabsig commented 1 year ago

I just figured out that the latex formulae are not properly displayed on mobile devices. For this reason, I prefer the current version. Apologies for this and thank you for the suggestion.

Ab2nour commented 1 year ago

I just figured out that the latex formulae are not properly displayed on mobile devices. For this reason, I prefer the current version. Apologies for this and thank you for the suggestion.

Ok, no problem for me! :grin: However, are you sure people look at repos like this on mobile? That might not be a problem, I don't really know :thinking:

fabsig commented 1 year ago

However, are you sure people look at repos like this on mobile?

I agree, it's only a small fraction. But given that the current solution is quite OK, I prefer to stay with it. Apologies again.

Ab2nour commented 1 year ago

No problem, have a nice day! :grin: