search

fabsig / GPBoost

Combining tree-boosting with Gaussian process and mixed effects models
Other
574 stars 46 forks source link

compile error #17

Closed aprilffff closed 3 years ago

aprilffff commented 3 years ago

cannot complie beacause of lack of ../GPBoost/external_libs/eigen/Eigen/Core and ../GPBoost/external_libs/eigen/Eigen/src/Core.

I have got them from official lightgbm code,pls update it for gpboost

fabsig commented 3 years ago

Can you please be more specific in how and what you are trying to compile?

aprilffff commented 3 years ago

just as your linux installation guide in https://github.com/fabsig/GPBoost/blob/master/docs/Installation_guide.rst

git clone --recursive https://github.com/fabsig/GPBoost cd GPBoost mkdir build cd build cmake .. make -j4

fabsig commented 3 years ago

I cannot reproduce this issue. For me, this works on Linux (Ubuntu 18.04). What do you mean by

I have got them from official lightgbm code

?

fabsig commented 3 years ago

Is this still an open issue? Otherwise, it will be closed soon.

fabsig commented 3 years ago

It might be that this is the same issue as in #23. For this, I added the "-DENABLE_PRECOMPILED_HEADERS=OFF" flag in CMakeLists which might solve the issue. However, as I cannot reproduce this on my machines, I cannot test this. If you have time, you could give it another try and let me know.

dan11mcguire commented 3 years ago

It might be that this is the same issue as in #23.

It is the same issue I think. If you look at versions 0.4.0 - 0.6.0, the Eigen directory does not have the Core file or the src/Core subdirectory. I was able to install the package only after switching to 0.3.0.

fabsig commented 3 years ago

@dan11mcguire: Thanks a lot for this useful hint. These Core directories have not been sinced by git since they were in the .gitignore file of Eigen (the reason for including them there is unclear to me). I have changed this and now they are also in GitHub.

Can somebody try again and check if it works now?