search

fabulous-dev / Fabulous.XamarinForms

Declarative UIs for Xamarin.Forms with F# and MVU, using Fabulous
https://docs.fabulous.dev/xamarinforms
Apache License 2.0
13 stars 1 forks source link

ImageButton CornerRadius property is an int not a float #37

Closed kevkov closed 1 year ago

kevkov commented 1 year ago

https://github.com/fabulous-dev/Fabulous.XamarinForms/blob/0514a6bc335e9641a78e5f2d961c8d8df8e319e7/src/Fabulous.XamarinForms/Views/Controls/ImageButton.fs#L23

https://learn.microsoft.com/en-us/dotnet/api/xamarin.forms.imagebutton.cornerradius?view=xamarin-forms

TimLariviere commented 1 year ago

@kevkov Thanks for the report!

Would you be interested to submit a PR for it? The changes would be quite small (eg changing defineBindableFloat -> defineBindableInt and change the corresponding modifier from float to int).

I will release a new version with your changes once merged :)

kevkov commented 1 year ago

Is this ok https://github.com/fabulous-dev/Fabulous.XamarinForms/pull/38 ?

TimLariviere commented 1 year ago

Your fix has been released in version 2.3.0 :)