search

fabulous-dev / Fabulous

Declarative UI framework for cross-platform mobile & desktop apps, using MVU and F# functional programming
https://fabulous.dev
Apache License 2.0
1.15k stars 122 forks source link

fix pedantic typo in various AboutAssets.txt #798

Closed cdituri closed 4 years ago

cdituri commented 4 years ago

"deployed with you package" => "deployed with your package"

Fabulous.XamarinForms/samples/FabulousWeather/Droid/Assets/AboutAssets.txt Fabulous.XamarinForms/samples/LoginShape/Droid/Assets/AboutAssets.txt Fabulous.XamarinForms/samples/ShapesDemo/Droid/Assets/AboutAssets.txt Fabulous.XamarinForms/templates/content/blank/NewApp.Android/Assets/AboutAssets.txt

Signed-off-by: Chris Dituri csdituri@gmail.com

cdituri commented 4 years ago

Another alternative would be to use git symlinks. That way there is one source of truth for AboutAssets.txt; and git symlinks are cross-platform across Windows, OS X, and Linux. The immediate downside is that all developers would need to ensure their git config has core.symlinks = true, which is not the git default.

src\Fabulous> git config -l | select-string ".*symlink.*"
core.symlinks=false

What's less clear to me is if using git symlinks would break any of Fabulous' internal plumbing or generation functionality. First time Fabulous user, and already loving it. Sending my thanks to the creators, maintainers, and contributors!

cdituri commented 4 years ago

Makes sense @TimLariviere. :+1: on everything you said re: symlinks and shipping the single template, while removing the samples copies. Thanks again!