Fix Template issue with WPF/UWP

fabulous-dev / Fabulous

Declarative UI framework for cross-platform mobile & desktop apps, using MVU and F# functional programming

https://fabulous.dev

Apache License 2.0

1.13k stars 122 forks source link

Fix Template issue with WPF/UWP #882

Closed SergejDK closed 2 years ago

SergejDK commented 3 years ago

@TimLariviere I think the problem with #881 was that the references for fabulous were missing.

I included this into both template proj files.

closes #881

TimLariviere commented 3 years ago

Weird it doesn't work anymore.

UWP and WPF projects use the SDK-Style format for csproj/fsproj so this implies several things:

We should use PackageReference instead of Reference for NuGet packages.
If a project references another project via ProjectReference, it should automatically reference all the PackageReferences from that other project.

And this is the case here: NewApp.fsproj imports the various Fabulous packages; NewApp.UWP/NewApp.WPF reference the project NewApp.

Looks like it's not automatically importing the NuGet packages from NewApp into the UWP/WPF projects anymore

SergejDK commented 3 years ago

So it seems like this is not the right way to go for this problem.

Found some other interesting parts which could help but I have to test them when I am back at my windows computer.

Is there an easy way to create uwp/wpf project from the templates folder?

TimLariviere commented 3 years ago

Is there an easy way to create uwp/wpf project from the templates folder?

I think now with .NET 5 there is a dotnet new template for WPF at least.

SergejDK commented 3 years ago

@TimLariviere yes dotnet new -i can install a template from a path. I'm currently looking into this issue and trying different things. The packagereference will work but it is kinda dirty.

SergejDK commented 3 years ago

@TimLariviere Found sth. interesting - Fabulous.XamarinForms version 1.1.0 references Fabulous 1.0. If I include Fabulous into the shared project so it will update to 1.1.0 it will work again. Do you have an idea where the reference is wrong then maybe I can fix that or should we just include Fabulous into the shared project?