search

fac-13 / jeth

Find jobs near you :computer:
https://jeth.herokuapp.com/
1 stars 2 forks source link

Server tests using external API call #29

Closed tdoran closed 6 years ago

tdoran commented 6 years ago

Hi team Jeth - love your project

I saw you're testing your API route for the type of its response and for errors (nice!) - I think ideally it would be best to do so without actually performing an external API call, by using nock.

https://github.com/fac-13/jeth/blob/master/src/test.js#L37-L59

(sidenote: we tried to do this with nock and couldn't get it working)

tdoran commented 6 years ago

Oops, I just realised you had this #16 issue open as a stretch goal! 🙌