missKatiaPunter
commented
6 years ago The plan was to have only a few pages displayed (run out of time). Having realised how many movies do not have posters made us think of appending movies from further pages to the end, though. That is what we'll try now.
These are pretty much UX (user experience) concerns, but they have an effect on your implementation & what functions you need to write in your code:
If I've just performed a search, I would probably expect to see the movies at the top of the screen & the page numbers at the bottom? Perhaps you could only show buttons for the first 3 pages, rather than all 100 at once?
But I get that the number of buttons on your page is dynamically generated based on how many pages numbers come back from the OMDB API query. In fact, it may be better to decouple what OMDB considers 1 page worth of results, from what your website considers 1 page? After all, a "page" is very specific to the UI of your website.
Having your page numbers being the same as OMDB's page numbers leads to some strange situations. e.g. there are 100 pages of results, but page 4 might have only 5 movies on it, so your grid of movie cards doesn't get filled.