Closed njons closed 5 years ago
Merging #114 into master will decrease coverage by
0.11%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
- Coverage 90.9% 90.78% -0.12%
==========================================
Files 12 11 -1
Lines 77 76 -1
Branches 5 5
==========================================
- Hits 70 69 -1
Misses 7 7
Impacted Files | Coverage Δ | |
---|---|---|
src/components/TopBar/BackButton.js | 100% <ø> (ø) |
|
src/components/Pages/Revision/SwipeBalls.js | 100% <ø> (ø) |
|
src/components/TopBar/TopBar.js | 100% <100%> (ø) |
|
src/components/Pages/Revision/RevisionTitle.js | 100% <100%> (ø) |
|
src/components/TopBar/CompleteButton.js | 66.66% <100%> (ø) |
|
src/components/Pages/Revision/RevisionPage.js | 77.77% <100%> (ø) |
|
src/components/Pages/Revision/RevisionContainer.js | 80% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bb56457...cc1a2ae. Read the comment docs.
Hey @Brymon, @sima-qian, @martingaston - I didn't realise that we/I left a PR waiting on Friday. 😱
Once it's merged, I'll pull the new master into this PR and let you know when its fully ready to review (meanwhile do feel free to wrap your head around the stuff I have listed in the description).
Making a note about merging the History
, Extras
and Examinations
components -- see #115
[x] Cleaned up component folder structure (further splitting needed)
[x] Fixed layout differences at the bottom of pages
[x] Made all pages accessible via the navbar render the same content (useful for planning how to split the first pages into dynamic content that can render in the different sections in case we get to that)
[x] created an anatomy Figma layout as a cheat sheet for the component names
[x] tests passing :heart: Travis