search

fac-14 / OSCEBossKey

Weeks 13-16 > Tech for Better project: An app to help medical students revise for their exams
https://oscebosskey.herokuapp.com/
MIT License
3 stars 2 forks source link

Keys in repo #147

Open tbtommyb opened 5 years ago

tbtommyb commented 5 years ago

You have a key hardcoded here. I don't know if it should be secret but even so it should be in the env file.

sima-qian commented 5 years ago

This is an interesting point. I don't think it's a key per se, rather it's an identifier for our database within airtable. In the airtable docs it's written in this way. You're right that it's worth moving it to a .env file for production.

tbtommyb commented 5 years ago

Ah in that case it doesn't matter about it being in the repo but yeah you'd still want to be able to set different values to choose between dev/production tables.