fac-14 / OSCEBossKey

Weeks 13-16 > Tech for Better project: An app to help medical students revise for their exams
https://oscebosskey.herokuapp.com/
MIT License
3 stars 2 forks source link

ResultsContainer #157

Open tbtommyb opened 5 years ago

tbtommyb commented 5 years ago

Just dumping a few things I noticed in this component:

Duplicating the array of elements here isn't required because both filter and map return new arrays so you aren't modifying the original props anyway.

Using an index as a key is generally an antipattern though I think you're ok here because you aren't changing the list once rendered.

You seem to have a lot of duplicated IDs on tags - is that intentional? IDs should be unique. One #revision-list is the actual list of missed items but the other one seems to be the score so I'm not sure why it's a list.