fac-14 / OSCEBossKey

Weeks 13-16 > Tech for Better project: An app to help medical students revise for their exams

https://oscebosskey.herokuapp.com/

MIT License

4 stars 2 forks source link

Navbar style #92

Closed Brymon closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #92 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #92   +/-   ##
======================================
  Coverage    92.5%   92.5%           
======================================
  Files          10      10           
  Lines          40      40           
  Branches        2       2           
======================================
  Hits           37      37           
  Misses          3       3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a5ced6d...549682c. Read the comment docs.

sima-qian commented 5 years ago

It looks beautiful! My only other comment is that it would be nice if the whole 'button' area of the navbar was a link, rather than just the icon.

martingaston commented 5 years ago

It looks beautiful! My only other comment is that it would be nice if the whole 'button' area of the navbar was a link, rather than just the icon.

I think you can do this with padding :+1: but i agree i think it looks mint

njons commented 5 years ago

if the whole 'button' area of the navbar was a link, rather than just the icon.

Hi guys! please make this an issue so we can deal with it when appropriate.

sima-qian commented 5 years ago

Hi guys! please make this an issue so we can deal with it when appropriate.

Already done! See #93