search

fac-14 / Week3TakingAIME

TFL + Giphy API Project
MIT License
2 stars 3 forks source link

Un-Accessibility #33

Closed vlbee closed 5 years ago

vlbee commented 5 years ago

By removing your :focus outlines in your CSS, you have made your site unaccessible to anyone who needs to use a keyboard for navigation.

https://github.com/fac-14/Week3TakingAIME/blob/master/style.css#L99-L106 image

Tip: If you have problems with the way outlines look by browser default, they can also be styled with CSS 😉

sima-qian commented 5 years ago

Shit, I thought the outline was just a cosmetic feature and I didn't like the clashing colours. Who built the internet this way!?

We'll fix this.

MissArray commented 5 years ago

Thanks for raising this.

Apparently, if an outline is really undesirable, there are alternative ways of improving accessibility: http://www.outlinenone.com/

sima-qian commented 5 years ago

Fixed on Code-review -fixes branch

sima-qian commented 5 years ago

Fixed in #42