search

fac-14 / Week3TakingAIME

TFL + Giphy API Project
MIT License
2 stars 3 forks source link

Let syntax #34

Closed samhstn closed 6 years ago

samhstn commented 6 years ago

Be careful with using let syntax. You should instead use var (here for example).

sima-qian commented 6 years ago

Oops! I recently did the ES6 section on freeCodeCamp so quite enthusiastic at the moment.

MissArray commented 6 years ago

Agree, thanks.

sima-qian commented 6 years ago

Fixed on Code-review-fixes branch

sima-qian commented 6 years ago

Fixed in #42

samhstn commented 6 years ago

There's still a let here: https://github.com/fac-14/Week3TakingAIME/blob/c6ffd81f55f60670aa2485adf26621e166fbfb66/logic.js#L28-L29

sima-qian commented 6 years ago

Bugger.