search

fac-14 / teamcoolerweek-2

To-do-list project
1 stars 1 forks source link

Double clone #22

Closed iPhatty closed 6 years ago

iPhatty commented 6 years ago

https://github.com/fac-14/teamcoolerweek-2/blob/4b588fb49da82ef7d3bdaea8458d8c7c54c80362/logic.js#L28-L29

Great to see you using some of the array methods you came across this week. Just note that concat also creates a new copy so it is not necessary to make use of the clonearray function. Nice one 😎

iPhatty commented 6 years ago

Its also the same for the deletetodo and marktodo. If you would like to know if they create a new one or not you can look at the MDN webdocs on the function and it will mention if it clones or not. Good stuff! 😀

morkeltry commented 6 years ago

..ooops.. I should have checked what issues are already made before adding a new one! #34