search

fac-14 / teamcoolerweek-2

To-do-list project
1 stars 1 forks source link

CSS units #26

Open morkeltry opened 6 years ago

morkeltry commented 6 years ago

Nice use of appropriate CSS units (vh, rem, %, px). I can see that you've chosen the different units appropriately based on their functionality.

Bear in mind, though, that not everyone will see and understand the choices behind that. You could be criticised for using a range of units, so in a tech test or something where you would be evaluated, it may be worth choosing a pair of base units (eg vw & rem) and adding a comment where there's a diversion from that.

sbinlondon commented 6 years ago

Thank you @morkeltry! I think we could have done much more commenting in general but it's good to know that people will look at things like use of units. cc @Zeanort @njons @thejoefriel