search

fac-14 / teamcoolerweek-2

To-do-list project
1 stars 1 forks source link

3700 lines of CSS for confetti? #44

Closed morkeltry closed 6 years ago

morkeltry commented 6 years ago

whaaaaaa?

There must be an less repeat-y way to do this! What happens when your client decides that all the confetti should be 10% lighter?

How about creating a set of style objects in JS which contain the same as your confetti-X classes, then creating the divs and appending your style objects in a JS function called at the end of <body>

The confetti is beautiful and all, and adds that extra sense of urgency to the todo list for those of us who might be tempted to go have a cup of tea instead of tackling the next item on it. But don't think we're going to let you get away with 3700 lines of code for a feature!!!

Also, for graphics made up of lines, look into coding SVGs - they take a few hours to learn, but are a handy way to solve graphical problems.

morkeltry commented 6 years ago

Ha ha! There was so much extra code, I scrolled straight past this bit: /* WEIRD SHIT - DO NOT CODE REVIEW, IT CAME FROM CODE PEN */

sbinlondon commented 6 years ago

I wish I could bash out 3.7K~ lines of CSS in one and a half days 😂 #goals!