fac-15 / CCSM

Charlie, Cynthia, Susan, Mike's portfolio website
https://fac-15.github.io/CCSM/
0 stars 3 forks source link

Form validation #11

Open sbinlondon opened 5 years ago

sbinlondon commented 5 years ago

It's great that you've implemented that to prevent bad inputs and empty inputs. I also like that it lets you know that the message has been sent - a good example of Neilsen's 'visibility of system status' heuristic 😉

I like that you've used regex but one thing to keep in mind is that some users may have Javascript turned off. You can also use HTML5 validation on your form in place of or in addition to your JS validation!

https://developer.mozilla.org/en-US/docs/Learn/HTML/Forms/Form_validation