HTML and CSS Stuff - Githubissues

fac-15 / I-Choose-Who-

Alex, Charlie, Sak and Jason's project. Heroku link -->

https://i-choose-who.herokuapp.com/

0 stars 0 forks source link

HTML and CSS Stuff #20

Open martinbagshaw opened 5 years ago

martinbagshaw commented 5 years ago

A few bits to add:

Title Tag
Meta Description
Viewport Meta tag
Image lacking alt tag
use sections
add h1 - h6 headings to sections (no untitled sections)
give a little intro to say what the app / webpage is about
label above text input element with for attribute the same as the id on the text input

CSS

Kinda covered by my design issue, but also could try following some guidelines in the style guides that Olly posted on the FAC 15 gitter: style guides for css, html, js. Basically suggests using classes over ids and elements to style

jcharnley commented 5 years ago

done title, added h1 heading. tried to fixed the css