search

fac-15 / casual-sports

Connecting those who want to do sports and exercise!
https://casual-sports.herokuapp.com/
3 stars 2 forks source link

Your commented-out tests work! #121

Closed rub1e closed 5 years ago

rub1e commented 5 years ago

From what I can see, your commented out database tests work for the most part - you just need to tweak them to match your linting rules (prefer-arrow-function)

That said, your error tests aren't working, and that's pretty important - you need to know if errors are thrown when they're supposed to be, otherwise your tests might be passing by accident

zurda commented 5 years ago

Thanks @rub1e , but these tests aren't arrow functions because they were commented out before we added the linter... They were passing locally for us as well, but they were failing once we pushed to Travis. We're not sure why.

We'll investigate this for sure, and try to fix the error testing :) thanks again for taking the time to dig into our code!

rub1e commented 5 years ago

Check out #125 - you're so close!

zurda commented 5 years ago

Oh! We sure will 😊 thanks!