search

fac-15 / casual-sports

Connecting those who want to do sports and exercise!
https://casual-sports.herokuapp.com/
3 stars 2 forks source link

Travis #125

Closed rub1e closed 5 years ago

rub1e commented 5 years ago

Your issue with travis isn't to do with Babel. Or at least, your main issue isn't with Babel.

I'll give you a hint...: http://www.yamllint.com/

Once you've got that up and running, you'll see that your tests (once you've fixed them per #121) all work, except for a couple. You should be able to figure it out just from the error messages you get in Travis (and you might find a good reason to start using what I talk about in #115)

What I can't figure out, though, is why they pass locally but not on travis. But I've never used travis so it's not immediately obvious to me what's going on. Also Spurs are on TV now, so that's yer lot for today.

image

rub1e commented 5 years ago

What I can't figure out, though, is why they pass locally but not on travis.

OK, so I've now figured out that this was caused by me misusing Jest rather than anything being wrong with travis.

(I still don't know why the tests were passing locally, but I corrected a small error (I'd put a test assertion in the wrong block) and now travis is working just fine)

So, apologies for the confusion - and again, you're soooooooo close

rub1e commented 5 years ago

(If any of the above is too vague/cryptic, just shout)

(But do try to figure it out for yourselves first)