fac18 / week6-coda-squall

https://coda-squall.herokuapp.com/
0 stars 0 forks source link

Unnecessary label content #55

Open oliverjam opened 4 years ago

oliverjam commented 4 years ago

The aria-labels on your submit buttons have a bit too much info in them.

For example "submit button for form to create new character"—the browser knows it's a submit button inside a form, so there's no need to duplicate this info.

It's also worth considering why you think non-sighted users need a different label in these cases. If "MAKE ME!" isn't enough info for a blind user, is it enough for a sighted one? You probably only need an alternative aria-label if the main one is purely visual (e.g. an icon).