search

fac19 / Cardley

Cardley the flash card app
https://cardley.netlify.app
0 stars 0 forks source link

Stylish morning #45

Closed tacotoemeck closed 4 years ago

tacotoemeck commented 4 years ago

  1. Merge Roger's PR,

  2. move style sheets out of:

    • practice.js
    • -twoSidedCard.js
    • oneSidedCard.js

  3. Fix oneSidedCard component

codecov[bot] commented 4 years ago

Codecov Report

Merging #45 into master will decrease coverage by 0.72%. The diff coverage is 22.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   24.07%   23.34%   -0.73%     
==========================================
  Files          28       30       +2     
  Lines         270      287      +17     
  Branches       44       46       +2     
==========================================
+ Hits           65       67       +2     
- Misses        186      199      +13     
- Partials       19       21       +2
Impacted Files Coverage Δ
src/components/cards/twoSidedCard.js 9.52% <0.00%> (-11.53%) :arrow_down:
src/components/pages/Practice/practice.js 5.71% <ø> (-2.62%) :arrow_down:
src/components/cards/oneSidedCard.js 13.33% <13.33%> (+13.33%) :arrow_up:
src/components/cards/cards-styles.js 100.00% <100.00%> (ø)
src/components/pages/Practice/practice.styles.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bfe651c...720ab3e. Read the comment docs.