search

fac19 / Cardley

Cardley the flash card app
https://cardley.netlify.app
0 stars 0 forks source link

Card editor #55

Closed Ivo-Evans closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #55 into master will increase coverage by 0.10%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   22.95%   23.05%   +0.10%     
==========================================
  Files          41       42       +1     
  Lines         440      451      +11     
  Branches       61       61              
==========================================
+ Hits          101      104       +3     
- Misses        312      320       +8     
  Partials       27       27
Impacted Files Coverage Δ
src/components/pages/InDeckCards/InDeckCards.js 0.00% <0.00%> (ø)
src/components/EditCard/EditCard.js 50.00% <50.00%> (ø)
src/utils/fetchData/backend-url.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d48725...f445c7b. Read the comment docs.

Ivo-Evans commented 4 years ago

we might want to add this on the server side to sanitise the html created by the editor, lest we send it back out to someone else.

This editor supports drag and drop image insertion, and encodes the image as a html tag binary. I haven't tried using that tag to render the response image. If it doesn't work or our server can't handle the data, we can remove the image button from the toolbar, and I imagine we can also disable drag and drop. If we do do images this way, we won't need front_image or back_image in the database any more.