search

fac19 / week1-guardians

https://fac19.github.io/week1-guardians/
0 stars 0 forks source link

BEM - stretch goals #31

Open renatadev opened 4 years ago

renatadev commented 4 years ago

I see you have BEM in your kanban board - it is going to be nice if you give it a try in the next project - but don't feel like this is something you must do, what is more important is the naming conventions that you as a team decide to follow and that you do follow them consistently and that's exactly what you've done - well done!

I'd recommend naming your ids in camelCase as ids are use for javascript!

jackherizsmith commented 4 years ago

Could make class names more consistent e.g. person / profile