search

fac19 / week11-where-is-whippy

An ice cream truck finder to connect local ice cream vendors with customers
https://where-is-whippy.netlify.app
1 stars 3 forks source link

npm i #74

Open Ivo-Evans opened 4 years ago

Ivo-Evans commented 4 years ago

installing dependencies is quite complicated because there's three npm packages (parent and two children) - maybe in the parent's package.json you could define a custom install command that installed all three, like npm i && cd server-api && npm i && cd ../client-app && npm i. I added this to scripts and it worked!

  "scripts": {
    "start": "node server.js",
    "test": "JWT_SECRET=mysecret PGDATABASE=travis_ci_test jest --coverage=true",
    "initdb": "node server-api/db/build.js",
    "deploy": "git subtree push --prefix server-api heroku master",
    "full-install": "npm i && cd server-api && npm i && cd ../client-app && npm i"
  },

(also would be helpful if in the ReadMe if you make it more clear/bold that you need to do npm install three times!!) (Vatsal)

Joepock123 commented 4 years ago

Run npm i on your terminal to install dependencies in the client-app/ server-api/ Root folder

Ye sorry guys maybe this could have been written a little more clearly as that is what I was getting at.