search

fac19 / week5-EIJO

Recipes database app
https://cookvid-19.herokuapp.com/
0 stars 2 forks source link

Error-handling #30

Closed oliverjam closed 4 years ago

oliverjam commented 4 years ago

https://github.com/fac19/week5-EIJO/blob/a2c98b816c645a3a5c2064915e13cc3564d8dce0/handlers/handlers.js#L18-L26

Don't forget to send a response to the browser when you catch an error like this. Otherwise the connection will stay open until the server eventually times out and cancels it.

You can probably see this in the Network tab in devtools: browser's by default make a request for /favicon.ico, which should be a 404 (as you don't have that file), but instead the request will time out and eventually fail.

oliverjam commented 4 years ago

Remember it's best to leave issues open until they're fixed (or to at least say if you don't plan on fixing it: you could use a WONTFIX label for that)