fac25 / week2-MarkupProject-Alex-Joe

https://fac25.github.io/week2-MarkupProject-Alex-Joe/
0 stars 0 forks source link

Footer overflow #37

Open oliverjam opened 2 years ago

oliverjam commented 2 years ago

https://github.com/fac25/week2-MarkupProject-Alex-Joe/blob/bcb7a56516e82910c7dca4f2f8bf6d80b22ddcc3/style.css#L190-L191

Your footer is overflowing horizontally (for me in Firefox at least). I believe this is because some browsers don't count the scrollbar width as part of the 100vw measurement. You may not have noticed this if you're on a Mac since they don't show scrollbars by default.

There are actually new viewport units being brought in to help in situations like this: https://web.dev/interop-2022/#new-viewport-units

Since <footer> is a block level element it should automatically fill the available width of the page, so you can probably just remove this rule entirely.

AlexPD93 commented 2 years ago

Thanks Olly!