fac26 / code-reviews

0 stars 3 forks source link

General Code review for Laura and Niete #11

Open konstantinakatmada opened 1 year ago

konstantinakatmada commented 1 year ago

README

Very nice README that describes the project using subheadings (Why?, What?, How? i.e.) and even gives instructions on how to clone it.

User stories

The project generally meets all of the user stories. With regards to the accessibility one (being able to use the site without a mouse) it is generally possible to do so, except for the sorting dropdown, which can only be used with the mouse. There also appears un unmet User Story about using CSS Grids as a style choice.

Learning outcomes

The project demonstrates the learning outcomes for that week exquisitely. There are numerous test functions, all of which pass.

UI bugs

When refreshing the page, one gets the ''Please keep your task name under 30 characters." message, even when the cursor is not at the input field. The function that displays this message is wrapped in a SetTimeOut function, which could be causing the issue.

Instructions

Everything works as expected from the instrunctions.

File structure

Javascript files could be put together in a new "scripts" folder.

Flow of control

I can follow the different paths the code might take.

Naming

Variables and functions have clear and descriptive names.

Readability

The code is perfectly understandable.