search

fac26 / code-reviews

0 stars 3 forks source link

To-Do TDD. Dominic S, Georgia & Derek. #9

Open GalKJ opened 1 year ago

GalKJ commented 1 year ago

README

The README is clear and explains why the code was written, what the code does and how we can run the app.

User stories

The project meets all user stories for this week bar the stretch user story of adding filter functionality.

Learning outcomes

This project doesn't appear to have been written using a TDD workflow, looking at past commits it's difficult to surmise if tests were written before code.

The test in the script.test.js file all fail currently and this should be looked into.

The JS functions to add, remove and check tasks all work very well. ✨

The app is responsive in mobile as well as tablet and desktop 👍

UI bugs

No bugs ✅ 🐛

Instructions

The instructions in the UI are brief but correct.

File structure

The file structure is nice and neat.

Flow of control

The code give a good sense of the direction the team are working towards.

Naming

They certainly do 🙂

Readability

The sudo code is understandable and clear.

LL835 commented 1 year ago

Hey @d0g3bl2 and @nataliarusu - really appreciate this feedback so thank you! The tests were the part we struggled with the most so we will definitely look into getting some passing tests before Thurs.