fac27 / Zaroff-s

Vercel: deploy
https://zaroff-s.vercel.app/
0 stars 0 forks source link

Taha's got issues #35

Open Taha-Hassan-Git opened 1 year ago

Taha-Hassan-Git commented 1 year ago

Love the Atoll joke.

Design is super cool, you've hit all the acceptance criteria from what I can see. I love the animate on scroll banner component. Very nice touch. The price filtering is also really slick. I can see you've used the context API, which is cool. Local storage is working and persisting data!

Some small issues, mostly to do with the UI.

V minor, but I enjoy doing these: Shouldn't this...

  const allRegions = [...new Set(getAllRegions().map(region => region.region))];

  const allPrices = [...new Set(getAllPrices().map(price => price.price))];

...be this?

  const allRegions = [...new Set(getAllRegions().map(island => island.region))];

  const allPrices = [...new Set(getAllPrices().map(island => island.price))];

🤷🏽

camelPhonso commented 1 year ago

@Taha-Hassan-Git, they should be that, yes!! I can't believe I didn't spot that.. ugly 😞