Open sgroi-l opened 1 year ago
Instructions for how to use/open the project. ie open index.html in a browser.
Yes
'Email us' is a link, but styled like a button. Lighthouse report says that the colour contrast between that and the background is not sufficient.
Twitter, Facebook and LinkedIn icons aren't clickable and don't link to anywhere.
Yes. Tabbing order skips over email in an unusual way.
Generally yes, some more comments in the JS files could be useful.
README
Instructions for how to use/open the project. ie open index.html in a browser.
User stories
Yes
Learning outcomes
'Email us' is a link, but styled like a button. Lighthouse report says that the colour contrast between that and the background is not sufficient.
UI bugs
Twitter, Facebook and LinkedIn icons aren't clickable and don't link to anywhere.
Instructions
Yes. Tabbing order skips over email in an unusual way.
File structure
Yes
Flow of control
Yes
Naming
Yes
Readability
Generally yes, some more comments in the JS files could be useful.