fac28 / code-reviews

0 stars 0 forks source link

[Thornberry Adventures] - code review #3

Open GeorgeKlemperer opened 1 year ago

GeorgeKlemperer commented 1 year ago

README

[Does the README describe the project using the subheadings: Why?, What?, How? i.e. Why have you created this repo, what does it do, how does it do it?]

Good ToC Nice headings and sub-headings

User stories

[Does the project meet the user stories for that week?]

Tabbing through website misses lots of sections. Responsiveness looks good. Nice use of repeatable styling, maybe need more css primitives to cut down on code? Nice grid structure used for team members.

Learning outcomes

[Does it demonstrate the learning outcomes for that week?]

UI bugs

[Can you see any obvious bugs or areas to improve?]

Nav-bar isn't a list (