fac28 / code-reviews

0 stars 0 forks source link

Valour Academy - code review #5

Open tess-phillips opened 1 year ago

tess-phillips commented 1 year ago

README

readme looks great. missing section on debugging and how made/planning?

User stories

tick. explained well in readme

Learning outcomes

as far as we can tell it meets most user outcomes. although firefox accessibilty checker flags up some stuff (but most of it is rubbish)

UI bugs

is there a way to say need 11 numbers for validation of telephone when click on pics there is more info (great!), would be nice to also see it when hovering to make sure no one misses the info really like how it looks during the first scroll also like the box shadow in navbar websites responsiveness is incredible programes images maybe dont go back to default batman pic? navbar pops below the logo

Instructions

First page - needs more direction on where to go from there (or make more obvious that there is content when you scroll down) (optional) (positive: once you do scroll it looks great!) When you hover on picture it moves (great). When you unhover it snaps back but would look better if it did the animation in reverse

File structure

tick in future can split the css for clearer

Flow of control

tick

Naming

tick

Readability

tick - js is nicely commented